Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes createTerminal does not create a terminal at the first editor group #169050

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Fixes createTerminal does not create a terminal at the first editor group #169050

merged 2 commits into from
Dec 15, 2022

Conversation

jeanp413
Copy link
Contributor

Fixes #166241

@jeanp413 jeanp413 mentioned this pull request Dec 13, 2022
Closed
@meganrogge meganrogge added this to the January 2023 milestone Dec 13, 2022
meganrogge
meganrogge approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works thank you 👍🏼

@Tyriar Tyriar merged commit bd63c3e into microsoft:main Dec 15, 2022
@jeanp413 jeanp413 deleted the fix-166241 branch December 15, 2022 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

createTerminal does not create a terminal at the first editor group
3 participants
@jeanp413 @Tyriar @meganrogge