Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the snippet source when the snippet with the same name appears #169119

Merged
merged 5 commits into from
Dec 19, 2022
Merged

add the snippet source when the snippet with the same name appears #169119

merged 5 commits into from
Dec 19, 2022

Conversation

weartist
Copy link
Contributor

@weartist weartist commented Dec 14, 2022 •
edited

resolved #160075

jrieken
jrieken requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so far. This is already good but I have made a few suggestions to polish this and to explore a different renderinger (see detail)

src/vs/workbench/contrib/snippets/browser/commands/configureSnippets.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/snippets/browser/commands/configureSnippets.ts Show resolved Hide resolved
src/vs/workbench/contrib/snippets/browser/commands/configureSnippets.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/snippets/browser/commands/configureSnippets.ts Outdated Show resolved Hide resolved
@weartist
Copy link
Contributor Author

Thanks so far. This is already good but I have made a few suggestions to polish this and to explore a different renderinger (see detail)

I will go and modify them, thank you for your help, it is very helpful to me！

@jrieken
Copy link
Member

jrieken commented Dec 19, 2022

Thanks @weartist. Pushed a small tweak on top to also show the relative path

Screenshot 2022-12-19 at 16 56 35

@jrieken jrieken added this to the January 2023 milestone Dec 19, 2022
@jrieken jrieken merged commit e106fd3 into microsoft:main Dec 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Snippets menu: differentiate between workspace and user snippets
3 participants
@weartist @jrieken @lramos15