Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAC: Smooth window resizing causes window managers not to be able to resize vscode #169123

Closed
patrickhuijten opened this issue Dec 14, 2022 · 6 comments · Fixed by #170879
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@patrickhuijten
Copy link

patrickhuijten commented Dec 14, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.74.0 (Universal)
  • OS Version: MacOS Monterrey 12.5.1 (21G83)

While using a window manager on Mac (Mosaic), I'm not able to resize / place the vscode window on the designated location on the screen.

This is relatively new behavior, can confirm this was not an issue prior to release 1.72.1. I believe this release https://github.com/microsoft/vscode/releases/tag/1.72.1 started this bug. vs code is the only application I know of that has this issue.

I included a screen recording showing the problem.
https://user-images.githubusercontent.com/36569812/207589262-52ab38ba-f500-41fc-aeb4-58f6d8bacd76.mov

Steps to Reproduce:

  1. Using a window manager (mosaic), drag and drop vscode into any of the resizing blocks.
@deepak1556
Copy link
Contributor

Mosaic requires a purchase, is there a repro with other open source window managers ?

In your demo, you seem to using native titlebar. Does the issue repro when launching with "window.titleBarStyle": "custom" ?

@deepak1556 deepak1556 added the info-needed Issue requires more information from poster label Dec 20, 2022
@patrickhuijten
Copy link
Author

Hi @deepak1556, I was unable to reproduce it with a free alternative from the apple store (Magnet).

Setting "window.titleBarStyle": "custom" was not successful either.

Normally I would approach the developer of Mosaic myself but it's only vs code that stands out here, every other app I know of (30+) work just fine. Even vs code used to work like any other app, hence this bug report.

Mosaic does have a 7 day free trial if that's of any help: https://www.lightpillar.com/mosaic.html

@deepak1556
Copy link
Contributor

Mosaic does have a 7 day free trial if that's of any help

I actually went for that but I just get pop-up that trial is expired on starting the application :(

I have an idea what might have caused this issue in the runtime, Can you maybe help with confirming the issue by following the steps below which requires running VSCode from source.

* Ensure build pre-requisites are available for your platform https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites
* git clone https://github.com/microsoft/vscode
* cd vscode
* yarn
* yarn compile
* ./scripts/code.sh

If the above steps are difficult to attempt now, I will try to provide a custom build later this week to verify.

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X confirmation-pending upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Dec 20, 2022
@patrickhuijten
Copy link
Author

patrickhuijten commented Dec 20, 2022

Thanks for the update. Will give this a try and get back to you 😄

@patrickhuijten
Copy link
Author

patrickhuijten commented Jan 2, 2023

Hi @deepak1556, sorry for the long wait. Happy new year by the way! 🎆

I followed your steps and I can confirm that running with Code - OSS from source I can resize/reposition windows just fine with Mosaic.

@deepak1556
Copy link
Contributor

Happy new year :) and Thanks for confirming.

As part of an accessibility experiment we disabled the AXManualAccessibility attribute in the runtime which looks like the Mosaic window manager relies on.

@deepak1556 deepak1556 added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues confirmed Issue has been confirmed by VS Code Team member and removed info-needed Issue requires more information from poster confirmation-pending labels Jan 3, 2023
@deepak1556 deepak1556 added this to the January 2023 milestone Jan 3, 2023
@mjbvz mjbvz added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants