Fix TS/JS Completion Item Provider for Completions that are not whole words #16955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… words Fixes microsoft#16888 **Bug** The js/ts completion provide can currently only complete whole words (as defined by `TextDocument.getWordRangeAtPosition`). This causes completion of literal string types to fail if they are not a whole word. **Fix** Instead of relaying on the default range, compute a range by taking the longest match of the replacement text from the current position.
mjbvz
commented
Dec 9, 2016
| if (entry.replacementSpan) { | ||
| let span: protocol.TextSpan = entry.replacementSpan; | ||
| // The indexing for the range returned by the server uses 1-based indexing. | ||
| // We convert to 0-based indexing. | ||
| this.textEdit = TextEdit.replace(new Range(span.start.line - 1, span.start.offset - 1, span.end.line - 1, span.end.offset - 1), entry.name); | ||
| } else { | ||
| const text = document.getText(new Range(position.line, Math.max(0, position.character - entry.name.length), position.line, position.character)); |
There was a problem hiding this comment.
This assume that the replacement text will always start with the replaced text. @dbaeumer is this a safe assumption to make. It worked in all cases in my testing, but we may want to scope the fix by only applying it to certain kinds of completion entries
|
The completions for the literal types are new in TS 2.1.x. In VSCode 1.7.2, we just treated the string values being completed as normal strings instead of types. I think we should hold off on merging this fix until post 1.8. I would like a period of testing in insiders for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16888
Bug
The js/ts completion provider can currently only complete whole words in most cases (as defined by
TextDocument.getWordRangeAtPosition). This causes completion of literal string types to fail if they are not a whole word.Fix
Instead of relaying on the default range, compute a range by taking the longest match of the replacement text backwards from the current position.