Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: warn not fail on UnknownError during signature verification #169777

Merged
merged 3 commits into from Dec 26, 2022
Merged

Extensions: warn not fail on UnknownError during signature verification #169777

merged 3 commits into from Dec 26, 2022

Conversation

dtivel
Copy link
Member

@dtivel dtivel commented Dec 21, 2022

Resolve #164726.

This change does a few things:

  1. Re-enables extension signature verification on Linux armhf.

  2. Logs a warning (not an error) if extension signature verification fails with UnknownError.

    Example of verification success:

    2022-12-21 11:13:55.387 [info] Extension signature verification: ms-vscode.cpptools. Verification status: Verified.
    

    Example of verification failure with UnknownError:

    2022-12-21 11:10:57.744 [warning] Extension signature verification: ms-vscode.cpptools. Verification status: UnknownError.
    
  3. Allows an extension install/update to proceed if extension signature verification failed with UnknownError.

  4. Reports via telemetry if extension signature verification failed with UnknownError.

Note that this PR does not fix the underlying problem (TBD) causing UnknownError.

CC @isidorn, @sandy081, @joaomoreno

@isidorn isidorn assigned sandy081 and unassigned mjbvz Dec 22, 2022
@isidorn isidorn added this to the January 2023 milestone Dec 22, 2022
@sandy081 sandy081 self-requested a review December 22, 2022 14:25
@sandy081 sandy081 added the extensions Issues concerning extensions label Dec 22, 2022
@sandy081
Copy link
Member

@dtivel Thanks for the changes.

Added a small change to use enum for verification status instead of two different properties.

sandy081
sandy081 previously approved these changes Dec 22, 2022
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@sandy081 sandy081 merged commit 32e8665 into microsoft:main Dec 26, 2022
@dtivel dtivel deleted the dtivel/unknown-error branch December 27, 2022 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature: UnknownError
5 participants