Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook toolbar dynamic label rendering #169790

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Fix notebook toolbar dynamic label rendering #169790

merged 2 commits into from
Dec 22, 2022

Conversation

rebornix
Copy link
Member

Fix #151460 and #165414. We render new actions always without label, which lead to these two bugs.

@rebornix rebornix self-assigned this Dec 22, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Dec 22, 2022
@rebornix rebornix merged commit 7d727a2 into main Dec 22, 2022
@rebornix rebornix deleted the rebornix/eager-hare branch December 22, 2022 05:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Delay of dynamic notebook toolbar action label visibility change
3 participants
@rebornix @Tyriar @VSCodeTriageBot