New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#162727: 'Debug:Run to cursor' command is now available in inactive d… #169819
Merged
roblourens
merged 7 commits into
microsoft:main
from
Viijay-Kr:feat-#162727-debug-run-to-cursor-while-inactive
Jan 31, 2023
Merged
#162727: 'Debug:Run to cursor' command is now available in inactive d… #169819
roblourens
merged 7 commits into
microsoft:main
from
Viijay-Kr:feat-#162727-debug-run-to-cursor-while-inactive
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
Viijay-Kr
force-pushed
the
feat-#162727-debug-run-to-cursor-while-inactive
branch
2 times, most recently
from
December 22, 2022 15:04
124bed3
to
609760b
Compare
roblourens
reviewed
Dec 29, 2022
Viijay-Kr
force-pushed
the
feat-#162727-debug-run-to-cursor-while-inactive
branch
3 times, most recently
from
January 9, 2023 16:27
8c3d057
to
b7bd2c6
Compare
Viijay-Kr
force-pushed
the
feat-#162727-debug-run-to-cursor-while-inactive
branch
from
January 10, 2023 08:03
b7bd2c6
to
e483823
Compare
roblourens
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry, I missed getting a second review for this, and ran out of time for this release. I'll be sure to merge it next week for the February release. |
Tyriar
approved these changes
Jan 31, 2023
mjbvz
approved these changes
Jan 31, 2023
mjbvz
approved these changes
Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the feature requested in #162727
This PR took the strategy mentioned in this comment
Refactorings
debuggerService.runTo
is refactored to support inactive debugger state