Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162727: 'Debug:Run to cursor' command is now available in inactive d… #169819

Conversation

Viijay-Kr
Copy link
Contributor

@Viijay-Kr Viijay-Kr commented Dec 22, 2022

Addresses the feature requested in #162727

This PR took the strategy mentioned in this comment

Refactorings

  1. The debuggerService.runTo is refactored to support inactive debugger state
  2. Two closures have been added to handle add and remove temp breakpoints.
  3. Remove breakpoints is attached to the listeners in the both the cases (Stopped and Inactive blocks)

@Viijay-Kr
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Viijay-Kr Viijay-Kr force-pushed the feat-#162727-debug-run-to-cursor-while-inactive branch 2 times, most recently from 124bed3 to 609760b Compare December 22, 2022 15:04
@Viijay-Kr Viijay-Kr force-pushed the feat-#162727-debug-run-to-cursor-while-inactive branch 3 times, most recently from 8c3d057 to b7bd2c6 Compare January 9, 2023 16:27
@Viijay-Kr Viijay-Kr force-pushed the feat-#162727-debug-run-to-cursor-while-inactive branch from b7bd2c6 to e483823 Compare January 10, 2023 08:03
@roblourens roblourens added this to the January 2023 milestone Jan 13, 2023
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens
Copy link
Member

Sorry, I missed getting a second review for this, and ran out of time for this release. I'll be sure to merge it next week for the February release.

@roblourens roblourens closed this Jan 31, 2023
@roblourens roblourens reopened this Jan 31, 2023
@roblourens roblourens merged commit 62dd7cd into microsoft:main Jan 31, 2023
@Viijay-Kr Viijay-Kr deleted the feat-#162727-debug-run-to-cursor-while-inactive branch January 31, 2023 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants