Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration perf tweaks #169828

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Configuration perf tweaks #169828

merged 4 commits into from
Dec 22, 2022

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Dec 22, 2022

  • turns out that the TST isn't the best way to use for affectsConfiguration. A very simply string-indexOf approach is really fast
  • add deltaConfiguration to configuration registry so that a single event is only use

…ation`. A very simply string-indexOf approach is really fast
…vent is only use

build list of changed properties on the fly to avoid extra iteration and distinct calls

adopt for extension point handling (with some assumptions)
@jrieken jrieken self-assigned this Dec 22, 2022
@jrieken jrieken changed the title joh/perf conf Configuration perf tweaks Dec 22, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Dec 22, 2022
- add a test for empty string
sandy081
sandy081 previously approved these changes Dec 22, 2022
@jrieken jrieken merged commit 8ee8862 into main Dec 22, 2022
@jrieken jrieken deleted the joh/perf-conf branch December 22, 2022 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants