Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't dispose internal2external commands before updating the UI #170566

Merged
merged 1 commit into from Jan 4, 2023
Merged

don't dispose internal2external commands before updating the UI #170566

merged 1 commit into from Jan 4, 2023

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jan 4, 2023

should fix #165244

@jrieken jrieken self-assigned this Jan 4, 2023
@jrieken jrieken enabled auto-merge (squash) January 4, 2023 16:36
@jrieken jrieken requested a review from bpasero January 4, 2023 16:36
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Jan 4, 2023
bpasero
bpasero approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jrieken jrieken merged commit b4b9972 into main Jan 4, 2023
@jrieken jrieken deleted the joh/fancy-marten branch January 4, 2023 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Status bar can dispose commands that are still in use
3 participants
@jrieken @bpasero @VSCodeTriageBot