Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable resolver on safe profile paths #170718

Merged
merged 1 commit into from Jan 6, 2023
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 6, 2023

Command Prompt was not being detected properly because of this regression.

Fixes #170563

Command Prompt was not being detected properly because of this regression.
@Tyriar Tyriar added this to the January 2023 milestone Jan 6, 2023
@Tyriar Tyriar requested a review from meganrogge January 6, 2023 19:36
@Tyriar Tyriar self-assigned this Jan 6, 2023
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Tyriar Tyriar merged commit b78d35a into main Jan 6, 2023
@Tyriar Tyriar deleted the tyriar/fix_var_resolver branch January 6, 2023 20:38
@philfuster
Copy link

🥳 Thank you Tyriar!

@Tyriar
Copy link
Member Author

Tyriar commented Jan 6, 2023

Sorry about the regression 😅

@philfuster
Copy link

hah! No problem at all. I totally get it. Thank you for your work.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated Terminal No Longer Working With "Command Prompt" profile or user defined profile (Cmder)
3 participants