Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for shell type to be ready before preparing path for shell #170720

Merged
merged 2 commits into from Jan 6, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 6, 2023

FIxes #169694

This goes against common style in the terminal and caused some confusion
@Tyriar Tyriar added this to the January 2023 milestone Jan 6, 2023
@Tyriar Tyriar requested a review from meganrogge January 6, 2023 19:48
@Tyriar Tyriar self-assigned this Jan 6, 2023
@Tyriar Tyriar enabled auto-merge January 6, 2023 19:49
@Tyriar Tyriar merged commit 5c92b13 into main Jan 6, 2023
@Tyriar Tyriar deleted the tyriar/169694_2 branch January 6, 2023 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double backslashes when workbench.action.terminal.runActiveFile is run with no active terminal
2 participants