Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile tests for else ifeq|ifneq|... syntax #170888

Merged
merged 4 commits into from Jan 12, 2023
Merged

Conversation

fadeevab
Copy link
Contributor

@fadeevab fadeevab commented Jan 9, 2023

@alexr00 @jrieken Hi folks, this is to test fadeevab/make.tmbundle@1d4c0b5

Merge this PR after pulling the fresh Makefile syntax.

Before:
image

After:
image

WHY: Found an original complaint about else ifeq

@fadeevab
Copy link
Contributor Author

fadeevab commented Jan 11, 2023

@alexr00 Would you be able to add an updated makefile test result file into this PR? I have problems to run tests on the WSL2 locally, I'm afraid it will take too much time for me.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the test!

@alexr00 alexr00 added this to the January 2023 milestone Jan 12, 2023
@alexr00 alexr00 merged commit 82305d3 into microsoft:main Jan 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants