Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move isHiddenByDefault #170889

Merged
merged 3 commits into from Jan 10, 2023
Merged

move isHiddenByDefault #170889

merged 3 commits into from Jan 10, 2023

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Jan 9, 2023

No description provided.

@sbatten sbatten enabled auto-merge (squash) January 9, 2023 19:03
@sbatten sbatten self-assigned this Jan 9, 2023
@sbatten sbatten requested review from jrieken and Tyriar January 9, 2023 19:03
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Jan 9, 2023
Tyriar
Tyriar previously approved these changes Jan 9, 2023
View reviewed changes
@sbatten sbatten disabled auto-merge January 9, 2023 19:08
@jrieken
Copy link
Member

jrieken commented Jan 10, 2023 •
edited

Thanks for following up. I pushed a little change that keeps all hide logic inside the PersistedMenuHideState object so that those arguments aren't needed anymore

@Tyriar Tyriar merged commit b535afb into main Jan 10, 2023
@Tyriar Tyriar deleted the sbatten/cheerful-swift branch January 10, 2023 14:57
@Tyriar
Copy link
Member

Tyriar commented Jan 10, 2023

@sbatten @jrieken this appears to now break the reason for the change in the first place; I cannot toggle visibility of the overflowed item anymore after this was merged:

image

image

@jrieken
Copy link
Member

jrieken commented Jan 10, 2023

Did you do the adoption of moving this default hide state into the menu registration?

@Tyriar
Copy link
Member

Tyriar commented Jan 10, 2023

Yep

image

@sbatten
Copy link
Member Author

sbatten commented Jan 10, 2023

@Tyriar not seeing the same issue
image
image

@Tyriar
Copy link
Member

Tyriar commented Jan 10, 2023

Let me try a full rebuild 🤔

@Tyriar
Copy link
Member

Tyriar commented Jan 10, 2023

My bad, I had the wrong group

@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

@Tyriar Tyriar Tyriar left review comments

Assignees

@sbatten sbatten

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbatten @jrieken @Tyriar @VSCodeTriageBot