Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf improvements in config land #170902

Merged
merged 1 commit into from Jan 9, 2023
Merged

perf improvements in config land #170902

merged 1 commit into from Jan 9, 2023

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Jan 9, 2023

  • improve parsing default config
  • remove freezing the model
  • improve setValue method
  • add/fix unit tests
  • reset default config only if cached default overrides exist

@sandy081
- improve parsing default config
027ddee 
- remove freezing the model
- improve setValue method
- add/fix unit tests
- reset default config only if cached default overrides exist
@sandy081 sandy081 enabled auto-merge (squash) January 9, 2023 20:46
@sandy081 sandy081 self-assigned this Jan 9, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Jan 9, 2023
@sandy081 sandy081 merged commit 8e33e69 into main Jan 9, 2023
@sandy081 sandy081 deleted the sandy081/painful-slug branch January 9, 2023 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandy081 @Tyriar @VSCodeTriageBot