Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add run recent and go to cwd to command decoration menu #171000

Merged
merged 1 commit into from Jan 12, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jan 10, 2023

Screenshot 2023-01-10 at 2 04 17 PM

fix #170979

@meganrogge meganrogge self-assigned this Jan 10, 2023
@meganrogge meganrogge added this to the January 2023 milestone Jan 10, 2023
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on this for now and bring up along with #170993 in the UX sync tomorrow

@meganrogge
Copy link
Contributor Author

I think we decided to go with this change, correct @Tyriar ? I think you mentioned removing the category, but IMO it feels more organized to keep the related ones grouped.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the only thing I'm not sure about is the first separator as it's a lot of categories, I think this is better as then the categories are:

  • Command-related actions
  • Terminal related actions
  • Help

image

It's also obvious that one deals with input and one with output because of Command/Output in the label. I'll let you decide whether we go with that or not, we can always change later.

@meganrogge meganrogge merged commit 865590e into main Jan 12, 2023
@meganrogge meganrogge deleted the merogge/menu-add branch January 12, 2023 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore having run recent command and go to recent directory in the shell integration menu
2 participants