add accessibility buffer #171118
add accessibility buffer #171118
Conversation
|
I notice mouse wheel events still skip the a11y buffer and go to the main terminal, ideally we would change that as well as when you click on it to not switch back to the main terminal view. |
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Oh, I thought that was by design as I thought ppl would be using the keyboard to navigate and mouse to escape |
meganrogge
changed the title
It was, but that was before I realized it would eventually enable keyboard caret selection. We can skip it for now as it's only on when you enable a11y mode. There are also low-vision users who may use screen readers and a mouse, so ideally it would work. |
| return; | ||
| } | ||
| // The viewport is undefined when this is focused, so we cannot get the cell height from that. Instead, estimate using the font. | ||
| const cellHeight = this._configHelper.getFont((this.xterm.raw as any)._core)?.charHeight || undefined; |
There was a problem hiding this comment.
Can you use this.xterm.getFont() instead?
| } | ||
| // The viewport is undefined when this is focused, so we cannot get the cell height from that. Instead, estimate using the font. | ||
| const cellHeight = this._configHelper.getFont((this.xterm.raw as any)._core)?.charHeight || undefined; | ||
| this._accessibilityBuffer.style.lineHeight = cellHeight ? (this._configurationService.getValue(TerminalSettingId.LineHeight) as number) * cellHeight + 'px' : ''; |
There was a problem hiding this comment.
getFont should return the lineHeight as well?
fixes #169853