Improve protocol link handling around windowId=_blank support
#171323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
changed the title
windowId=_blank support
bpasero
commented
Jan 15, 2023
bpasero
commented
Jan 15, 2023
bpasero
commented
Jan 15, 2023
|
Good to go for a review. |
joaomoreno
approved these changes
Jan 16, 2023
joaomoreno
approved these changes
Jan 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol links can use
windowId=_blankto indicate that they want a fresh window to be handled in. This works fine in most cases except when VS Code is not running. In that case, we first restore the previous session only then to open another empty window to handle the protocol link in. A better solution is to open an empty window right from the beginning and then handle the link in there.The code that deals with protocol links is incredibly complex and spaghetti. Will try to cleanup the existing implementation but will resort to explanatory comments in most cases where cleanup is not helping reduce complexity.
Refs: https://github.com/github/codespaces/issues/9792