Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -r over -f in bash si script #171495

Merged
merged 1 commit into from Jan 17, 2023
Merged

Use -r over -f in bash si script #171495

merged 1 commit into from Jan 17, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 17, 2023

-r is for 'readable', -f is for 'regular files'

Called out in #170870 (review)

@Tyriar
Use -r over -f in bash si script
89eb5b9 
-r is for 'readable', -f is for 'regular files'
@Tyriar Tyriar added this to the January 2023 milestone Jan 17, 2023
@Tyriar Tyriar self-assigned this Jan 17, 2023
@Tyriar Tyriar mentioned this pull request Jan 17, 2023
Merged
meganrogge
meganrogge approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but lgtm

@Tyriar Tyriar merged commit 4f3f8c3 into main Jan 17, 2023
@Tyriar Tyriar deleted the tyriar/hyphen_r branch January 17, 2023 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tyriar @meganrogge