Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwsh autocomplete #171648

Merged
merged 27 commits into from Jan 19, 2023
Merged

Pwsh autocomplete #171648

merged 27 commits into from Jan 19, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 18, 2023

Part of ##154662

It's a bit rough around the edges currently but it's behind the terminal.integrated.shellIntegration.suggestEnabled setting

image


After chatting with @jrieken and further thinking, this is the approach I'm taking for the workbench suggest widget:

image

workbench/services/suggest will extend the editor/suggest where trivial, otherwise things will be forked. This will make the review/abstraction/etc. burden on editor/suggest low.

If it makes sense to avoid editor components in certain parts of editor/suggest later, we could move some to platform. That's not that important from my perspective though.

image

@Tyriar Tyriar added this to the January 2023 milestone Jan 18, 2023
@Tyriar Tyriar self-assigned this Jan 18, 2023
@Tyriar Tyriar marked this pull request as ready for review January 19, 2023 15:13
@Tyriar
Copy link
Member Author

Tyriar commented Jan 19, 2023

@meganrogge this is ready for a review, I'd like to get it in asap so I can start doing smaller incremental changes and track things in issues. Everything is behind a new setting so it should be fairly safe. It's not worth doing a big review of the suggest stuff as it's mostly a fork with parts commented out, which will get cleaned up later.

meganrogge
meganrogge previously approved these changes Jan 19, 2023
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

meganrogge
meganrogge previously approved these changes Jan 19, 2023
meganrogge
meganrogge previously approved these changes Jan 19, 2023
@Tyriar Tyriar closed this Jan 19, 2023
@Tyriar Tyriar reopened this Jan 19, 2023
@Tyriar Tyriar enabled auto-merge January 19, 2023 21:03
@Tyriar Tyriar merged commit df931c9 into main Jan 19, 2023
@Tyriar Tyriar deleted the tyriar/154662 branch January 19, 2023 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants