Set title on webviews #171766
Merged
Set title on webviews #171766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#170440 This sets the `title` on webview iframe elements
TylerLeonhardt
previously approved these changes
Jan 19, 2023
TylerLeonhardt
approved these changes
Jan 19, 2023
jeanp413
reviewed
Feb 7, 2023
| @@ -12,8 +12,6 @@ | |||
| </head> | |||
|
|
|||
| <body style="margin: 0; overflow: hidden; width: 100%; height: 100%" role="document"> | |||
| <!-- TODO: Remove additional script tag once Firefox is fixed https://bugzilla.mozilla.org/show_bug.cgi?id=1737882 --> | |||
| <script></script> | |||
jeanp413
added a commit
to jeanp413/vscode
that referenced
this pull request
Feb 7, 2023
Deleted in microsoft#171766
jeanp413
added a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Feb 7, 2023
Deleted in microsoft#171766
jeanp413
added a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Feb 7, 2023
Deleted in microsoft#171766
mjbvz
pushed a commit
that referenced
this pull request
Feb 7, 2023
Reapplies firefox workaround. Deleted in #171766
mjbvz
pushed a commit
to mjbvz/vscode
that referenced
this pull request
Feb 7, 2023
Reapplies firefox workaround. Deleted in microsoft#171766
mjbvz
added a commit
that referenced
this pull request
Feb 7, 2023
c-claeys
pushed a commit
to c-claeys/vscode
that referenced
this pull request
Feb 16, 2023
Reapplies firefox workaround. Deleted in microsoft#171766
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170440
This sets the
titleon webview's iframe elements for accessibility