Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename command-center command to "Quick Pick" #171808

Merged
merged 2 commits into from Jan 20, 2023
Merged

rename command-center command to "Quick Pick" #171808

merged 2 commits into from Jan 20, 2023

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jan 20, 2023

fyi @sbatten, related to #170621

@jrieken jrieken self-assigned this Jan 20, 2023
@jrieken jrieken enabled auto-merge (squash) January 20, 2023 10:08
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Jan 20, 2023
bpasero
bpasero requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why "Quick Pick"? Typically we refer to the more complex pickers as "Quick Open". What is the context in which a user would select this command?

@jrieken
Copy link
Member Author

jrieken commented Jan 20, 2023

No strong feelings, any name is good that doesn't duplicate "Command Center". Tho, quick open also isn't consistently used. Unsure how to call this

Screenshot 2023-01-20 at 12 25 08

@jrieken jrieken requested a review from bpasero January 20, 2023 11:31
@bpasero
Copy link
Member

bpasero commented Jan 20, 2023

Oh ok, I think I get it now:

  • "Command Center" is the entire block of "Go Back/Forward, Quick Open"
  • within you can toggle visibility of Go Back/Forward and Quick Open

Since we make use of "Quick Open" in settings extensively, I think this is ok

image

@jrieken jrieken merged commit fd05813 into main Jan 20, 2023
@jrieken jrieken deleted the joh/governing-dragonfly branch January 20, 2023 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrieken @bpasero @VSCodeTriageBot