Don't add extra right margin to layout controls #172306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft#168910 added a right margin between layout control elements. However this also added a right margin to the last element, shifting the layout controls right by 4px This change switch to use `gap` instead so that there's a 4px margin between elements but no extra margin for the set of layout control buttons
sbatten
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#168910 added a right margin between layout control elements. However this also added a right margin to the last element, which means that the layout controls are now all shifted left by 4px
This change switch to use
gapinstead so that there's a 4px margin between elements but no extra margin for the entire set of layout control buttonsCurrent is top, new is bottom: