Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve styling of terminal accessibility help #172397

Merged
merged 1 commit into from Jan 30, 2023
Merged

improve styling of terminal accessibility help #172397

merged 1 commit into from Jan 30, 2023

Conversation

meganrogge
Copy link
Contributor

fix #172344
Screenshot 2023-01-25 at 9 03 19 AM

@meganrogge meganrogge self-assigned this Jan 25, 2023
@meganrogge meganrogge added this to the January 2023 milestone Jan 25, 2023
@Tyriar Tyriar modified the milestones: January 2023, February 2023 Jan 25, 2023
@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2023

I suggested a different approach in #172408 (comment), not sure if it's better

@meganrogge
Copy link
Contributor Author

meganrogge commented Jan 25, 2023 •
edited

I tried your approach and the scrollbars/ top anchor look rough IMO. The centered styling in this PR aligns well with the one in the editor. Do you have concerns about specific layouts with this approach?

@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2023

Oh I thought the scroll bars would only show if the container exceeded the allowed space? That was for the edge case where the terminal is so small that it needs one. This is fine, I just normally do this type of thing via translate

Tyriar
Tyriar approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but let's leave to February as it missed testing and is low priority

@meganrogge meganrogge merged commit f6382a4 into main Jan 30, 2023
@meganrogge meganrogge deleted the merogge/help-css branch January 30, 2023 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
February 2023
Development

Successfully merging this pull request may close these issues.

Terminal Accessibility Help dialog stretches from bottom of terminal panel
2 participants
@meganrogge @Tyriar