increase search area of quick fixes #172471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jan 25, 2023
src/vs/workbench/contrib/terminal/browser/terminalQuickFixBuiltinActions.ts
Show resolved
Hide resolved
Tyriar
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #172068
below you see oss then insider's - always reproes if you have 3 splits that are pretty narrow in insider's, but not oss
this is because we check only
lengthlines wherelengthis the number\nin a possibly wrapped string. it often exceeds the length of 5, so we don't find a match. 15 is arbitrary, but seems to work in my testing without being too manyfix.mov