Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #172384 #172800

Merged
merged 1 commit into from Jan 31, 2023
Merged

Fixes #172384 #172800

merged 1 commit into from Jan 31, 2023

Conversation

hediet
Copy link
Member

@hediet hediet commented Jan 30, 2023 •
edited

Fixes #172384

Inline completion providers can now implement the following method:

handleDidPartiallyAcceptCompletionItem: async (completionItem, acceptedLength) => {
	console.log('partially accepted', acceptedLength, completionItem.insertText.substr(0, acceptedLength));
},

acceptedLength refers to the number of actual characters that have been accepted from completionItem (after the snippet is resolved and brackets are auto-completed).

@hediet hediet requested a review from jrieken January 30, 2023 13:37
@VSCodeTriageBot VSCodeTriageBot added this to the February 2023 milestone Jan 30, 2023
@hediet hediet merged commit 93feda3 into main Jan 31, 2023
@hediet hediet deleted the hediet/miserable-manatee branch January 31, 2023 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@hediet hediet

Labels
None yet
Projects
None yet
Milestone
February 2023
Development

Successfully merging this pull request may close these issues.

Partial acceptance of Inline suggestions skips command
3 participants
@hediet @jrieken @VSCodeTriageBot