New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix accessibility support status bar on reload and window open #172934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not suggesting to store this in UI state (storage service) but just in a property of the service. I do not think we can assume that after a restart, accessibility mode is still on, or can we?
I am not fully understanding why we cannot do this:
- vscode starts
- we check if a18n is on from the main process
- we pass this as value to windows on startup
- we keep the value in a variable in the a18n service
- the status bar reads it
- we also update from events as we do today
I misunderstood when I read cache because typically the storage service is where we do that. I will try that approach |
f779162
to
a177bab
Compare
src/vs/workbench/services/accessibility/electron-sandbox/accessibilityService.ts
Outdated
Show resolved
Hide resolved
accessibilitySupport
so status bar entry is correct regardless of event timingThis reverts commit 39954d2.
cefd764
to
b0bff68
Compare
@deepak1556 from your comments, I thought this was more than a UX/status bar item issue. But in my testing, it's just that. This fix is simple & works |
fix #172690
fix #172688