Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong language scope in markdown inline math expression #172957

Merged

Conversation

robincaloudis
Copy link
Contributor

@robincaloudis robincaloudis commented Jan 31, 2023

Why

In #148644, it was shown
that given a markdown inline math with $$
when the cursor position is directly in front
of the closing dollar symbol then that the language
scope shows markdown instead of the language
scope latex.

What

Previously, the first and third group was
defined as beginning. This is not
true as the first group of the regular
expression is the beginning of the math
inline markdown expression and the third
group the end. Once the third group is
correctly assigned, its language scope can
be changed accordingly.

Fixes #148644

Previously, the first and third group was
defined as beginning. This is not
true as the first group of the regular
expression is the beginning of the math
inline markdown expression and the third
group the _end_. Once the third group is
correctly assigned, its language scope can
be changed accordingly.
@robincaloudis
Copy link
Contributor Author

@microsoft-github-policy-service agree

@mjbvz mjbvz enabled auto-merge (squash) January 31, 2023 21:04
@robincaloudis
Copy link
Contributor Author

robincaloudis commented Feb 1, 2023

Hello @Tyriar and @mjbvz, thanks for the review! How do I get a successful check on revent yarn.lock changes in PRs? Currently, it is not reported and marked as Expected — Waiting for status to be reported

@robincaloudis
Copy link
Contributor Author

robincaloudis commented Feb 1, 2023

Hi again @Tyriar and @mjbvz, could you tell me why I still see Merging is blocked - Merging can be performed automatically with 1 approving review. even though both of you have approved? Do you have to re-approve as I merged the branch main into my branch? Best, Robin

@mjbvz mjbvz merged commit 63b07db into microsoft:main Feb 1, 2023
@robincaloudis robincaloudis deleted the robincaloudis/fix-language-scope branch February 3, 2023 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

language scope markdown math
3 participants