Fix wrong language scope in markdown inline math expression #172957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In #148644, it was shown
that given a markdown inline math with $$
when the cursor position is directly in front
of the closing dollar symbol then that the language
scope shows markdown instead of the language
scope latex.
What
Previously, the first and third group was
defined as beginning. This is not
true as the first group of the regular
expression is the beginning of the math
inline markdown expression and the third
group the end. Once the third group is
correctly assigned, its language scope can
be changed accordingly.
Fixes #148644