Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper syntax highlighting of shell aliases in v1.75 #173224

Closed
fabiospampinato opened this issue Feb 2, 2023 · 6 comments · Fixed by #173574
Closed

Improper syntax highlighting of shell aliases in v1.75 #173224

fabiospampinato opened this issue Feb 2, 2023 · 6 comments · Fixed by #173574
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@fabiospampinato
Copy link
Contributor

fabiospampinato commented Feb 2, 2023

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: v1.75.0
  • OS Version: 12.5.1

Steps to Reproduce:

Screen Shot 2023-02-02 at 23 21 11

alias brew_list="brew leaves"
alias brew-list="brew leaves"

As you can see aliases are syntax-highlighted differently depending on if there's an hyphen or an underscore in them, which looks like a bug to me.

@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@fabiospampinato fabiospampinato changed the title Improper syntax highlighting of shell aliases in v1.70 Improper syntax highlighting of shell aliases in v1.75 Feb 2, 2023
@fabiospampinato
Copy link
Contributor Author

I read the version number wrong.

@RedCMD
Copy link
Contributor

RedCMD commented Feb 3, 2023

Can confirm it working correctly in 1.72.2
but has been broken in 1.75.0

Prob should move report to https://github.com/jeff-hykin/better-shell-syntax
already fixed? jeff-hykin/better-shell-syntax#29

related: #173216

@alexr00
Copy link
Member

alexr00 commented Feb 6, 2023

This one doesn't appear to be fixed with the latest out of https://github.com/jeff-hykin/better-shell-syntax. Copied the issue there: jeff-hykin/better-shell-syntax#37

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels Feb 6, 2023
@alexr00 alexr00 added this to the February 2023 milestone Feb 6, 2023
@alexr00
Copy link
Member

alexr00 commented Feb 6, 2023

Assigning to the February milestone so I remember to check back in and see if this has been fixed.

@alexr00
Copy link
Member

alexr00 commented Feb 6, 2023

It's been fixed!

@alexr00 alexr00 closed this as completed Feb 6, 2023
@alexr00 alexr00 removed this from the February 2023 milestone Feb 6, 2023
@alexr00 alexr00 removed the bug Issue identified by VS Code Team member as probable bug label Feb 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants