Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in problems view show black when not focused #173276

Merged
merged 2 commits into from Feb 3, 2023

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Feb 3, 2023

Fixes #173148

Includes the following changes:

  • make IKeybindingLabelStyles and IProgressBarStyles consistent with other styles
  • allow that IStyleOverride can remove a color use by setting a property to undefined

The fix for the problems view icon color issue is to unset the listInactiveSelectionIconForeground color as the problems view list entries each get different colors based on problem severity. These are set with css on top of the list and must not be overwitten for inactive selection items

@aeschli aeschli enabled auto-merge (squash) February 3, 2023 10:11
@aeschli aeschli self-assigned this Feb 3, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the February 2023 milestone Feb 3, 2023
@aeschli aeschli requested a review from alexr00 February 3, 2023 11:07
@aeschli aeschli merged commit d4d77fb into main Feb 3, 2023
@aeschli aeschli deleted the aeschli/fascinating-yak-448 branch February 3, 2023 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons in problems view show black when not focused
3 participants