update tokio #173784
Merged
update tokio #173784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Feb 8, 2023
| @@ -16,7 +16,7 @@ futures = "0.3" | |||
| clap = { version = "3.0", features = ["derive", "env"] } | |||
| open = { version = "2.1.0" } | |||
| reqwest = { version = "0.11.9", default-features = false, features = ["json", "stream", "native-tls-vendored"] } | |||
| tokio = { version = "1.23", features = ["full"] } | |||
| tokio = { version = "1.24.2", features = ["full"] } | |||
There was a problem hiding this comment.
Seems like the lock file picked up more recent version 1.25.0, should this instead be bumped to the same ?
There was a problem hiding this comment.
Cargo will match using ^ by default, unless otherwise given in the lockfile. Changing this caused cargo to re-resolve and just match the latest 1.x. The update should be fine imo; no breaking changes.
connor4312
approved these changes
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.