Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List items get rules for quick picks or suggest lists #173805

Closed
bpasero opened this issue Feb 8, 2023 · 4 comments · Fixed by #173832
Closed

List items get rules for quick picks or suggest lists #173805

bpasero opened this issue Feb 8, 2023 · 4 comments · Fixed by #173832
Assignees
@aeschli
Labels
insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken themes Color theme issues
Milestone
February 2023

Comments

@bpasero
Copy link
Member

bpasero commented Feb 8, 2023

I see this from time to time, it is not just happening reproducible. I wonder if it could be caused by more CSS getting loaded:

image
@bpasero bpasero added themes Color theme issues regression Something that used to work is now broken labels Feb 8, 2023
@bpasero
Copy link
Member Author

bpasero commented Feb 8, 2023

The CSS rule triggering this seems to be:

image

I wonder how that is possible.

//cc @TylerLeonhardt

@Tyriar
Copy link
Member

Tyriar commented Feb 8, 2023

Related: #173611, #172668

@aeschli
Copy link
Contributor

aeschli commented Feb 8, 2023

While trying to reproduce today, I also came to strange scenarios where the stylesheet for a list would contain rules for the suggest widget list.

@aeschli aeschli changed the title Icons are white List items get rules for quick picks or suggest lists Feb 8, 2023
@aeschli aeschli added this to the February 2023 milestone Feb 8, 2023
@aeschli aeschli mentioned this issue Feb 8, 2023
Merged
@aeschli
Copy link
Contributor

aeschli commented Feb 8, 2023

Ok, found the problem 🤭

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken themes Color theme issues
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

List items get rules for quick picks or suggest lists microsoft/vscode
5 participants
@bpasero @Tyriar @aeschli @daviddossett @VSCodeTriageBot