Icons in problems view show black when not focused #174487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
previously approved these changes
Feb 15, 2023
Tyriar
approved these changes
Feb 15, 2023
c-claeys
pushed a commit
to c-claeys/vscode
that referenced
this pull request
Feb 16, 2023
* Icons in problems view show black when not focused * update smoke test
|
This merge make icon in Problems as Table View always black? I think it should be
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the severity icon in markers view in a container node that gets the severity icon color as foreground color.
That way, if the icon color of the list view entry is not set, the color of container is used.
That also works also with colors set as css variable. If a color is not set, the variable in invalid and
inheritis used as color.inheritmeans using the container color.FYI @joaomoreno
Fixes #173148