-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench actions for Tree Fuzzy Search Toggle #175137
Conversation
@microsoft-github-policy-service agree |
Contiguous Spelled wrong Co-authored-by: John Murray <johnm@georgejames.com>
Co-authored-by: John Murray <johnm@georgejames.com>
Co-authored-by: John Murray <johnm@georgejames.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes made in the latest commit.
Hi @joaomoreno, I think it's ready for re-review. I have made the requested changes in 3443042 |
@gjsjohnmurray @joaomoreno Are there any pending changes that I have to implement to close this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs reviews by team members, and I am not one. Pinging @joaomoreno
Thanks for your contribution! I have simplified it to become a simple toggle. 🍻 |
Fixes #173866
Changes
- Explorer: Toggle Find Match Type
- Explorer: Switch to Fuzzy Find Match Type
- Explorer: Switch to Contagious Find Match Type
Technical Changes
explorerActions.ts
invs/base/browser/actions/explorerActions.ts
and registered the actions in it.findMatchType
was required in AsyncDataTree for this to be modified from an action. Async Data Tree was modified accordingly.