Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find/replace: Keyboard shortcuts for "whole word" and "case" toggles only work in the search field #17577

Closed
atombender opened this issue Dec 20, 2016 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded

Comments

@atombender
Copy link

Cmd-Alt-W (toggle whole word) and Cmd-Alt-C (toggle case sensitivity) only work in the editor and when the "Find" field has focus. They do not work in the "Replace" input, for example.

Which is annoying when you've typed what to find, have already tabbed to the "Replace" input, realize that the "whole word" toggle is on, and then try to toggle it back with Cmd-Alt-W, which doesn't work.

The keyboard shortcuts should work in all of the panel's inputs.

@egamma egamma added the editor-find Editor find operations label Dec 20, 2016
@alexdima
Copy link
Member

alexdima commented Mar 2, 2017

@atombender This works for me on Linux (where the keybinding is alt+c). Can you please search for cmd+alt+c in the keybindings and report here what entries there are. The command in question is toggleFindCaseSensitive and the entry should look like this:

{ "key": "alt+c",                 "command": "toggleFindCaseSensitive",
                                     "when": "editorFocus" },

i.e. when any editor is focused it should toggle.

@alexdima alexdima added the info-needed Issue requires more information from poster label Mar 2, 2017
@alexdima alexdima added this to the Backlog milestone Mar 2, 2017
@atombender
Copy link
Author

I'm referring to the "Search" sidebar panel, not the little find box that pops up on Cmd+F. Alt+Cmd+C works fine in the latter. The former is defined as:

{ "key": "alt+cmd+c",             "command": "toggleSearchCaseSensitive",
                                     "when": "searchInputBoxFocus && searchViewletVisible" },

It would seem that searchInputBoxFocus is blocking it from working except in the first input box in that panel.

@alexdima alexdima removed the editor-find Editor find operations label Mar 8, 2017
@alexdima alexdima removed their assignment Mar 8, 2017
@alexdima alexdima removed this from the Backlog milestone Mar 8, 2017
@sandy081 sandy081 added search Search widget and operation issues bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 8, 2017
@sandy081 sandy081 added this to the Backlog milestone Mar 8, 2017
@sandy081 sandy081 modified the milestones: Backlog, September 2018 Sep 14, 2018
@miguelsolorio miguelsolorio added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants