fail with more info #175814
Merged
fail with more info #175814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #175729
Test has failed 2 times in a span of over 2 months and doesn't seem to fail locally.
This change should make the workflow in the test more predictable and provide more details on how it fails if it does agian.
When testing locally I found that
onDidChangeNotebookDocumentcan fire more often than expected - sometimes the event fires twice for a cell add edit, and therefore we don't wait for the event after executing. But the test failure is due to timing out waiting for that event, so that does not help explain the failures.