Introduce proposed editor line number context menu #175840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
approved these changes
Mar 2, 2023
| import { IBreakpointEditorContribution, BREAKPOINT_EDITOR_CONTRIBUTION_ID } from 'vs/workbench/contrib/debug/common/debug'; | ||
|
|
||
| class EditorLineNumberContextMenu extends Disposable implements IEditorContribution { | ||
| private readonly menu = this._register(this.menuService.createMenu(MenuId.EditorLineNumberContext, this.contextKeyService)); |
There was a problem hiding this comment.
For a context menu it is actually favourable to create and dispose it on demand, e.g. this.editor.onContextMenu, because menu comes with the cost of being context key listeners - of which there are plenty and which fire a lot
| key: 'editor/lineNumber/context', | ||
| id: MenuId.EditorLineNumberContext, | ||
| description: localize('editorLineNumberContext', "The contributed editor line number context menu"), | ||
| proposed: 'contribShareMenu' |
There was a problem hiding this comment.
Should this be a dedicated proposal or is the re-use of shareMenu intentional?
There was a problem hiding this comment.
It's intentional for now because the only extension-contributed actions I foresee coming into this menu are Copy GitHub Permalink and Copy vscode.dev Link initially--but it will probably make sense to make this a standalone proposal soon. Done in main
joyceerhl
added a commit
that referenced
this pull request
Mar 2, 2023
Minimizes listener creation for context key service, #175840 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #175676, #175945