Observe lineNumber if there is no active selection or if the active selection does not contain the specified line number
#176432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selection does not contain the specified line number
Tyriar
requested changes
Mar 7, 2023
Tyriar
approved these changes
Mar 7, 2023
| @@ -91,6 +86,12 @@ function getFileAndPosition(context: LinkContext): IFilePosition | INotebookPosi | |||
| return undefined; | |||
| } | |||
|
|
|||
| function getRangeOrSelection(lineNumber: number | undefined) { | |||
| return lineNumber !== undefined && (!vscode.window.activeTextEditor || vscode.window.activeTextEditor.selection.isEmpty || !vscode.window.activeTextEditor.selection.contains(new vscode.Position(lineNumber - 1, 0))) | |||
There was a problem hiding this comment.
is this that same long conditional as the other PR?
There was a problem hiding this comment.
yes, the link code is duplicated between desktop and vscode.dev :/
There was a problem hiding this comment.
there's been discussion of centralizing it but it would be a lot more work than we're willing to invest (at least as of the last time it was discussed)
TylerLeonhardt
approved these changes
Mar 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.