Use the CommandQuickAccess provider #176682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested changes
Mar 9, 2023
This is a command I introduced to help me with some debugging related efforts. It was never intended to work in standalone monaco. Additionally, this command has not shipped in any stable version and is prefixed with |
TylerLeonhardt
previously approved these changes
Mar 9, 2023
|
FYI @bpasero would love your thoughts |
TylerLeonhardt
approved these changes
Mar 9, 2023
bpasero
requested changes
Mar 10, 2023
| @@ -127,6 +124,13 @@ export class CommandsQuickAccessProvider extends AbstractEditorCommandsQuickAcce | |||
| })); | |||
| } | |||
|
|
|||
| public getCommandInfo(): Array<ICommandQuickPick> { | |||
There was a problem hiding this comment.
Suggested change
| public getCommandInfo(): Array<ICommandQuickPick> { | |
| getCommandInfo(): Array<ICommandQuickPick> { |
| @@ -227,4 +231,15 @@ export class ClearCommandHistoryAction extends Action2 { | |||
| } | |||
| } | |||
|
|
|||
| //#region --- Register a command to get all actions from the command palette | |||
| CommandsRegistry.registerCommand('_getAllCommands', async function (accessor: ServicesAccessor) { | |||
There was a problem hiding this comment.
Why do we need this? It is somewhat ugly that we instantiate a UI component here only to get to the commands. Maybe the functionality for getting the commands should better be extracted to its own function or class?
lramos15
added a commit
that referenced
this pull request
Mar 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears the
MenuRegistryis missing editor commands for the command palette so commands likeFormat Documentare not available.Maybe we should think about switching to the
CommandRegistryat some point, but for now the command palette has nice names for common commads which makes finding what you want for development easy.