Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change extension order for Diff language id #17672

Closed
JimiC opened this issue Dec 21, 2016 · 2 comments · Fixed by #17680
Closed

Change extension order for Diff language id #17672

JimiC opened this issue Dec 21, 2016 · 2 comments · Fixed by #17680
Assignees
@bpasero
Milestone
January 2017

Comments

@JimiC
Copy link
Contributor

JimiC commented Dec 21, 2016 •
edited
Loading

Currently the order is:

  • .patch
  • .diff
  • .rej

This creates a visual issue when using different images for diff and patch.

Currently we on vscode-icons do so and although the associated files get the correct image, in the Language Mode selection it shows the patch image and not the diff image.

Changing the order to:

  • .diff
  • .patch
  • .rej

or

  • .diff
  • .rej
  • .patch

should fix the issue.
This was referenced Dec 21, 2016
Closed
Merged
@egamma
Copy link
Member

egamma commented Dec 21, 2016

The issue refers to this https://github.com/Microsoft/vscode/blob/master/extensions/diff/package.json#L11

@JimiC
Copy link
Contributor Author

JimiC commented Dec 21, 2016

Submitted #17680

@bpasero bpasero added this to the January 2017 milestone Dec 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
January 2017
Development

Successfully merging a pull request may close this issue.

Change order of Diff extensions.
3 participants
@egamma @bpasero @JimiC