Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create problem collector when no problem matchers, but don't process lines #176818

Merged
merged 1 commit into from Mar 10, 2023
Merged

create problem collector when no problem matchers, but don't process lines #176818

merged 1 commit into from Mar 10, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Mar 10, 2023 •
edited

fix #176496

follow up to / regression from #175376

users will now see this (if they haven't already responded to it) but the window will actually open ✅

Screenshot 2023-03-10 at 1 40 28 PM

@meganrogge meganrogge self-assigned this Mar 10, 2023
@meganrogge meganrogge added this to the March 2023 milestone Mar 10, 2023
@meganrogge meganrogge merged commit b62c32e into main Mar 10, 2023
@meganrogge meganrogge deleted the merogge/problem-collectors branch March 10, 2023 23:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@alexr00 alexr00 Awaiting requested review from alexr00

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

A missing problem matcher results in the debugger not launching
2 participants
@meganrogge @Tyriar