Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the flat kernel picker #176992

Merged
merged 4 commits into from Mar 15, 2023
Merged

Remove the flat kernel picker #176992

merged 4 commits into from Mar 15, 2023

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Mar 13, 2023

For #168535

As discussed, we will remove the old flat kernel picker. Using the MRU picker is already the default

@mjbvz mjbvz added this to the March 2023 milestone Mar 13, 2023
@mjbvz mjbvz requested a review from rebornix March 13, 2023 18:59
@mjbvz mjbvz self-assigned this Mar 13, 2023
@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 13, 2023

@rebornix Can you help with the unit test failures. I added some additional stubs but am still not sure why the tests are failing

@rebornix
Copy link
Member

@mjbvz I can take a look. BTW, do we check how many users on 1.76 change their kernel picker setting? I think it's low but wanna make sure.

@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 14, 2023

@rebornix Thanks!

In the past 14 days, 40 machines have changed the setting. We don't know if they have turned this feature on or off, only that they changed the setting

Given this very low usage, I suggest we remove the old kernel picker

@mjbvz mjbvz enabled auto-merge (squash) March 14, 2023 19:25
@mjbvz mjbvz merged commit f67be70 into microsoft:main Mar 15, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants