Don't skip JS/TS diagnostic updates on equals #177149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the diagnostics on the ext host side may be equal, the displayed diagnostic may be at a different spot. We need to make sure the UI is also updated in these cases by setting the diagnostics again
roblourens
approved these changes
Mar 15, 2023
|
I think this also fixed an issue I just hit when pasting in text where the line before an error changes length. errorSpanIssuesOnPaste.mp4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the diagnostics on the ext host side may be equal, the displayed diagnostic may be at a different spot as we shift around markers on edit. We need to make sure the UI is also updated in these cases by setting the diagnostics again
Fixes #169443