Make terminal tab hover keyboard accessible

[Tyriar]

There's a new Terminal: Show or Focus Hover command which shows it and then focuses it if screen reader optimized mode is on.

focusTrap is used so if you hit escape when focused, focus will return to the previous element (probably the actual terminal).

Fixes #177232

[meganrogge]

I didn't know this command existed. I wonder how we can make it more discoverable for both the editor and terminal - maybe it should be in the accessibility help menus?

[meganrogge]

has some conflicts

[Tyriar]

@meganrogge it's working well on latest/mac now.

[meganrogge]

@Tyriar now I see it in the command palette and running that works, but the keyboard shortcut still doesn't work for me when there's just a single tab. Terminal: clear takes precedence

[Tyriar]

@meganrogge oh ok, in that case it's kind of working as designed... That keybinding is important on macOS and it disables all chords. Does it work when the focus is in the tabs list? If so I think this situation is fine as it's accessible, the fact that you could show the hover while the terminal was focused was just a bonus.

[meganrogge]

I worry because this feature is super nice, but as I mentioned, most screen reader users will have only one terminal open here, which is the case where this won't work atm. Could we set a higher weight for this keybinding as compared with clear? Or use a different one that does not involve K? What about ctrlCmd+I so it's still discoverable?

[Tyriar]

ctrlCmd+I wouldn't be discoverable though as it's not used elsewhere. How about we disable cmd+k in a11y mode as I doubt it would be useful there anyway?

[Tyriar]

@meganrogge could you test this again? I'm not on my mac atm

[meganrogge]

Shows up in a funny spot, but now works, so 👍🏼