Making the sticky scroll keep focus when the sticky lines disappear on scrolling #177813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiday-mar
added
feature-request
Tyriar
approved these changes
Mar 21, 2023
| this._stickyScrollWidget.setState(this._widgetState); | ||
| this._focusedStickyElementIndex = this._stickyElements.length - 1; | ||
| if (this._focusedStickyElementIndex !== -1) { | ||
| (this._stickyElements.item(this._focusedStickyElementIndex) as HTMLDivElement).focus(); |
There was a problem hiding this comment.
You could store _stickyElements as a HTMLElement[] to avoid these casts spread throughout the file:
this._stickyElements = Array.from(this._stickyScrollWidget.getDomNode().childNodes) as HTMLElement[]You should also be able to use HTMLElement here instead of the more specific HTMLDivElement.
There was a problem hiding this comment.
Thanks for the tip! The issue is that I need to access the original children HTML elements. The above code creates a copy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177770