Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement indent guide colorization options. #178112

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

mwerschy
Copy link
Contributor

Resolves #158242. Apparently, this isn't possible to do properly in extensions, c.f. oderwat/vscode-indent-rainbow#3.

Broken colorization with extension:
Screenshot

With native implementation:
Screenshot

This likely breaks themes trying to use the single option name. What is the intended migration path for settings?

@mwerschy
Copy link
Contributor Author

@microsoft-github-policy-service agree

@hediet hediet added this to the April 2023 milestone Mar 27, 2023
@hediet
Copy link
Member

hediet commented Mar 27, 2023

@aeschli what's the recommended way to rename color variables?

@aeschli
Copy link
Contributor

aeschli commented Mar 27, 2023

If the existing color is not yet used very much, breaking is ok.
If it is part of several themes, I suggest that the new color(s) use the old color as default value. The old color can be marked deprecated.

@mwerschy
Copy link
Contributor Author

Well, I have no idea how widely used it is. They're marked as deprecated and used as defaults now.

@Igorgro
Copy link

Igorgro commented Apr 3, 2023

Probably default guides colors should match brackets colors (yellow, purple, blue)

@hediet hediet modified the milestones: April 2023, May 2023 Apr 24, 2023
@hediet hediet modified the milestones: May 2023, June 2023 May 26, 2023
@hediet hediet modified the milestones: June 2023, July 2023 Jun 27, 2023
@hediet hediet merged commit 6bbb128 into microsoft:main Jul 5, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indent Colorization
5 participants