Remove non-null assertions in searchWidget [debt] #178256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Mar 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171527
Fixes #170907
Non-null assertions have been causing telemetry errors.
In this implementation, I put warn messages when we skip registering listeners, since that might have a lasting effect on how the search viewlet is initialized. However, in most of these cases, the field should have already implemented (via a function directly or indirectly called by the constructor) except for some cases (ie: when the state is saved too early like in the first issue)
As mentioned in #170875 (comment), all non-null assertions can be tech debt, so I'm removing them all from the Search Widget.