Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a few more tests out of electron-browser #178305

Merged
merged 2 commits into from Mar 25, 2023
Merged

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Mar 25, 2023

No description provided.

@bpasero bpasero enabled auto-merge (squash) March 25, 2023 06:15
@VSCodeTriageBot VSCodeTriageBot added this to the March 2023 milestone Mar 25, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreamah @roblourens fyi this test was skipped so I decided to remove it. if you feel strong about it, then please look into restoring it on a layer that is not electron-browser which will eventually disappear. See #171508 for context.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was skipped because it was a "run on demand" test. I haven't looked at it in a long time, up to you @andreamah whether it's worth doing the work to keep. We haven't done any work in a long time that impacts backend search perf, you might just consider bringing it back if you do that kind of work in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to bring it back then maybe consider to turn it into a node.js only test without electron dependencies if possible 👍

@bpasero bpasero merged commit 9fc749b into main Mar 25, 2023
7 checks passed
@bpasero bpasero deleted the ben/obedient-bandicoot branch March 25, 2023 17:53
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants