Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf - allow unicode in strings again #178579

Merged
merged 1 commit into from Mar 29, 2023
Merged

perf - allow unicode in strings again #178579

merged 1 commit into from Mar 29, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Mar 29, 2023

No description provided.

@VSCodeTriageBot VSCodeTriageBot added this to the April 2023 milestone Mar 29, 2023
@ulugbekna
Copy link
Contributor

I wonder why we're again allowing them?

@bpasero
Copy link
Member Author

bpasero commented Mar 29, 2023

@ulugbekna turns out, esbuild already converts unicodes in strings to unicode escape sequences. So my change is really only needed in RegEx, not elsewhere.

See: https://esbuild.github.io/api/#charset

@bpasero bpasero merged commit e1c4a6d into main Mar 29, 2023
7 checks passed
@bpasero bpasero deleted the ben/central-halibut branch March 29, 2023 14:45
trbot86 pushed a commit to trbot86/vscode that referenced this pull request Mar 29, 2023
@bpasero @trbot86
perf - allow unicode in strings again (microsoft#178579)
8ffde1f
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bpasero @ulugbekna @alexr00 @VSCodeTriageBot