Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Markdown preview styles to prevent sub and sup from affecting line height #178653

Merged
merged 1 commit into from Mar 30, 2023

Conversation

teddybradford
Copy link
Contributor

@teddybradford teddybradford commented Mar 30, 2023

This PR adds a style to the Markdown previews CSS to prevent sub and sup elements from affecting line height, which currently affects the flow of text lines.

For example:

Screenshot 2023-03-30 at 12 50 13 AM

(Note the extra vertical space marked in red.)

And then with the proposed CSS applied:

Screenshot 2023-03-30 at 12 50 41 AM


For reference, Normalize.css (a common CSS reset) does this as well.

@mjbvz mjbvz enabled auto-merge (squash) March 30, 2023 17:10
@mjbvz
Copy link
Contributor

mjbvz commented Mar 30, 2023

Thanks! Should be in the next VS Code 1.78 insiders build

@mjbvz mjbvz merged commit b244524 into microsoft:main Mar 30, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2023
@teddybradford teddybradford deleted the markdown-preview-styles branch July 23, 2023 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants