Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Settings editor search result count #178842

Merged
merged 1 commit into from Mar 31, 2023

Conversation

rzhao271
Copy link
Contributor

Ref #158531

When searching for settings, the same setting sometimes shows up in two ToC (table of contents) groups. The search result label and aria status then uses that count instead of the deduplicated count. The deduplicated count makes more sense, considering that the search results are shown deduplicated.

@rzhao271 rzhao271 self-assigned this Mar 31, 2023
@rzhao271 rzhao271 enabled auto-merge (squash) March 31, 2023 19:46
@rzhao271 rzhao271 added this to the April 2023 milestone Mar 31, 2023
@rzhao271 rzhao271 merged commit 1859288 into main Mar 31, 2023
7 of 8 checks passed
@rzhao271 rzhao271 deleted the rzhao271/a11y-settings-editor-count branch March 31, 2023 20:01
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants